nastra commented on code in PR #7321:
URL: https://github.com/apache/iceberg/pull/7321#discussion_r1163855751
##########
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/DataGenerators.java:
##########
@@ -124,10 +125,12 @@ private org.apache.avro.Schema
fixupAvroSchemaConvertedFromIcebergSchema(
LogicalTypes.timeMillis()
.addToSchema(
org.apache.avro.Schema.create(org.apache.avro.Schema.Type.INT));
- field = new org.apache.avro.Schema.Field("time_field",
fieldSchema);
+ updatedField = new
org.apache.avro.Schema.Field("time_field", fieldSchema);
+ } else {
Review Comment:
maybe init `updatedField = field` at the beginning rather than having an
`else`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
