jackye1995 commented on code in PR #7277:
URL: https://github.com/apache/iceberg/pull/7277#discussion_r1156433313
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueToIcebergConverter.java:
##########
@@ -45,7 +45,7 @@ static TableIdentifier toTableId(Table table) {
*/
static void validateTable(Table table, String fullName) {
String tableType =
table.parameters().get(BaseMetastoreTableOperations.TABLE_TYPE_PROP);
- ValidationException.check(
+ NoSuchIcebergTableException.check(
Review Comment:
From the perspective of this util method, it does not make much sense to
throw `NoSuchIcebergTableException`. I would propose just do a try-catch in
`doRefresh` and throw the right exception there and add a few lines of
documentation for why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
