danielcweeks commented on code in PR #7270:
URL: https://github.com/apache/iceberg/pull/7270#discussion_r1156224074
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -131,6 +135,26 @@ private ScheduledExecutorService tokenRefreshExecutor() {
return tokenRefreshExecutor;
}
+ @Value.Lazy
+ Cache<String, AuthSession> authSessionCache() {
+ long expirationIntervalMs =
+ PropertyUtil.propertyAsLong(
+ properties(),
+ CatalogProperties.AUTH_SESSION_TIMEOUT_MS,
+ CatalogProperties.AUTH_SESSION_TIMEOUT_MS_DEFAULT);
Review Comment:
I think a 24 hour idle timeout would more closely align with patterns where
a table is accessed and left idle. Beyond that, it's very unlikely the
reference will be used again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
