deepyaman opened a new pull request, #7242: URL: https://github.com/apache/iceberg/pull/7242
I'm proposing a minimal change to relax `fsspec`, `s3fs`, `adlfs` again (after https://github.com/apache/iceberg/pull/6745 relaxed a bit). Specifically, I want to be able to leverage https://github.com/fsspec/s3fs/pull/704 (or https://github.com/fsspec/filesystem_spec/pull/1194) to provide the endpoint URL. Previously, I was doing something custom: ```diff - load_catalog( - "default", - **{ - "s3.endpoint": os.environ.get("PYICEBERG_CATALOG__DEFAULT__S3_ENDPOINT") - }, - ) + load_catalog("default") ``` However, since [asking about this on Slack](https://apache-flink.slack.com/archives/C03G7LJTS2G/p1679979247415609), I've found that most environment variables will be read by `pyiceberg` by way of `s3fs` (e.g. `AWS_ACCESS_KEY_ID`, `AWS_SECRET_ACCESS_KEY`), and that `fsspec`/`s3fs` have recently provided (better) ways to even configure endpoint URL. So I'd like to leverage them. :) As somebody developing a library that has a dependency on `pyiceberg`, there's a broader issue of not pinning versions so tightly, but I will create a separate issue on that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
