a-recknagel commented on code in PR #4797:
URL: https://github.com/apache/iceberg/pull/4797#discussion_r1151809061
##########
python/src/iceberg/types.py:
##########
@@ -208,6 +208,10 @@ def __init__(self, *fields: NestedField, **kwargs):
fields = kwargs["fields"]
object.__setattr__(self, "fields", fields)
+ # This __post_init__ call is needed as IcebergType is not a dataclass
+ def __post_init__(self):
+ super().__init__()
Review Comment:
Just in case it ever does come up, `IcebergType ` can be protected from
having frozen-dataclass-children by using `object.__setattr__` for assignments
instead of `=`, e.g. instead of `self.x = x` do `object.__setattr__(self, 'x',
x)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
