RussellSpitzer commented on code in PR #7188:
URL: https://github.com/apache/iceberg/pull/7188#discussion_r1146867666
##########
api/src/main/java/org/apache/iceberg/io/LocationProvider.java:
##########
@@ -28,6 +28,16 @@
* <p>Implementations must be {@link Serializable} because instances will be
serialized to tasks.
*/
public interface LocationProvider extends Serializable {
+
+ /**
+ * Return a fully-qualified data location for a table.
Review Comment:
Redundant javadoc, for these we usually just do a one liner, no annotation
```java
/**
Returns a fully-qualified data location for a table
**/
```
But I would also argue we should be a bit more descriptive, what is a "data
location"
Additionally, do we want to have a default here? Shouldn't it be illegal to
not provide this method? I think the intent here is not to break old location
providers, but since the new code references this method I'm not sure we can
get around it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
