Reo-LEI commented on code in PR #7171:
URL: https://github.com/apache/iceberg/pull/7171#discussion_r1144681193
##########
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSink.java:
##########
@@ -390,4 +393,45 @@ public void testOverrideWriteConfigWithUnknownFileFormat()
{
return null;
});
}
+
+ @Test
+ public void testPartitionEvolution() throws Exception {
+ List<List<Row>> rows =
+ IntStream.range(0, 10)
+ .mapToObj(i -> createRows(String.valueOf(i)))
+ .collect(Collectors.toList());
+
+ DataStream<Row> dataStream = env.addSource(new BoundedTestSource<>(rows),
ROW_TYPE_INFO);
+
+ FlinkSink.forRow(dataStream, SimpleDataUtil.FLINK_SCHEMA)
+ .table(table)
+ .tableLoader(tableLoader)
+ .writeParallelism(parallelism)
+ .append();
+
+ Thread thread = null;
+ if (partitioned) {
+ thread =
+ new Thread(
+ () -> {
+ try {
+ Thread.sleep(120);
Review Comment:
I think we can test spce changes in `TestIcebergFilesCommitter` instead of
testing here by starting another thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
