stevenzwu commented on code in PR #7109:
URL: https://github.com/apache/iceberg/pull/7109#discussion_r1142865328
##########
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/FlinkSource.java:
##########
@@ -291,7 +294,25 @@ public DataStream<RowData> build() {
if (env.getMaxParallelism() > 0) {
parallelism = Math.min(parallelism, env.getMaxParallelism());
}
- return env.createInput(format, typeInfo).setParallelism(parallelism);
+
+ DataStreamSource<RowData> source =
Review Comment:
another possible common place to evaluate the residual filter is probably
`RowDataFileScanTaskReader`. This approach also brings a benefit that it
doesn't change the shape of Flink DAG. E.g., users won't see an extra filter
function/operator and wonder where does it come from.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
