liuxiaocs7 commented on code in PR #7134:
URL: https://github.com/apache/iceberg/pull/7134#discussion_r1142537816
##########
data/src/test/java/org/apache/iceberg/io/TestPartitioningWriters.java:
##########
@@ -137,11 +137,10 @@ public void testClusteredDataWriterOutOfOrderPartitions()
throws IOException {
writer.write(toRow(4, "bbb"), spec, partitionKey(spec, "bbb"));
writer.write(toRow(5, "ccc"), spec, partitionKey(spec, "ccc"));
- AssertHelpers.assertThrows(
- "Should fail to write out of order partitions",
- IllegalStateException.class,
- "Encountered records that belong to already closed files",
- () -> writer.write(toRow(6, "aaa"), spec, partitionKey(spec, "aaa")));
+ Assertions.assertThatThrownBy(
+ () -> writer.write(toRow(6, "aaa"), spec, partitionKey(spec,
"aaa")))
+ .isInstanceOf(IllegalStateException.class)
+ .hasMessageContaining("Encountered records that belong to already
closed files");
Review Comment:
Hi, @nastra thanks for your suggestion, I have added some more rules to make
the check more strict, please take a look again for me in your free time,
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
