JonasJ-ap commented on code in PR #7136: URL: https://github.com/apache/iceberg/pull/7136#discussion_r1140948167
########## .github/workflows/python-integration.yml: ########## @@ -17,7 +17,7 @@ # under the License. # -name: "Python CI" +name: "Python Integration" Review Comment: If two CI have the same name, the following error occurs some time:  ########## python/tests/conftest.py: ########## @@ -80,6 +80,12 @@ ) +def pytest_collection_modifyitems(items: List[pytest.Item]) -> None: + for item in items: + if not any(item.iter_markers()): + item.add_marker("unmarked") Review Comment: Added based on comment in https://github.com/apache/iceberg/pull/6392#discussion_r1049285936 to activate the marker "unmarked" in Makefile ########## python/Makefile: ########## @@ -27,7 +27,7 @@ lint: test: poetry run coverage run --source=pyiceberg/ -m pytest tests/ -m unmarked ${PYTEST_ARGS} - poetry run coverage report -m --fail-under=90 + poetry run coverage report -m --fail-under=88 Review Comment: The current coverage excluding integration, s3, and adlfs tests is 88% ########## python/tests/io/test_pyarrow.py: ########## @@ -450,17 +450,11 @@ def test_expr_not_null_to_pyarrow(bound_reference: BoundReference[str]) -> None: def test_expr_is_nan_to_pyarrow(bound_double_reference: BoundReference[str]) -> None: - assert ( - repr(expression_to_pyarrow(BoundIsNaN(bound_double_reference))) - == "<pyarrow.compute.Expression (is_null(foo, {nan_is_null=true}) and is_valid(foo))>" - ) + assert repr(expression_to_pyarrow(BoundIsNaN(bound_double_reference))) == "<pyarrow.compute.Expression is_nan(foo)>" def test_expr_not_nan_to_pyarrow(bound_double_reference: BoundReference[str]) -> None: - assert ( - repr(expression_to_pyarrow(BoundNotNaN(bound_double_reference))) - == "<pyarrow.compute.Expression invert((is_null(foo, {nan_is_null=true}) and is_valid(foo)))>" - ) + assert repr(expression_to_pyarrow(BoundNotNaN(bound_double_reference))) == "<pyarrow.compute.Expression invert(is_nan(foo))>" Review Comment: To reflect the changes made in https://github.com/apache/iceberg/pull/6398/files#diff-49144c27eab7e03926b0310aa8b513dbeb9c8d2a0d33bacf8dedbd88b4680aacR431-R435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
