ajantha-bhat commented on PR #6789:
URL: https://github.com/apache/iceberg/pull/6789#issuecomment-1465909953

   >  While the code looks technically correct, this change introduces an 
unnecessary extra round-trip. Usually, people work on the HEAD of a Nessie 
branch, which, for most Nessie operations, does not require the client to know 
the HEAD's commit-ID and pass it back to the server.
   IMO the NessieIcebergClient needs to be able to handle the case of 
referencing the HEAD of a branch for NessieCatalog (and only pass the 
branch/tag name to the Nessie server), but be able provide an instance of 
NessieIcebergClient with the expected hash / commit ID for newTableOps, 
renameTable, dropTable, etc.
   
   @snazy, @dimas-b, @nastra: I have avoided the unnecessary extra round-trip 
by fixing it differently than before. Please take a look. Thanks. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to