jackye1995 commented on code in PR #6965: URL: https://github.com/apache/iceberg/pull/6965#discussion_r1129084416
########## spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestUnpartitionedWritesToBranch.java: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.spark.sql; + +import java.util.Map; +import org.apache.iceberg.Table; +import org.apache.iceberg.exceptions.ValidationException; +import org.assertj.core.api.Assertions; +import org.junit.Test; + +public class TestUnpartitionedWritesToBranch extends TestUnpartitionedWrites { + + private static final String BRANCH = "test"; + + public TestUnpartitionedWritesToBranch( + String catalogName, String implementation, Map<String, String> config) { + super(catalogName, implementation, config); + } + + @Override + public void createTables() { + super.createTables(); + Table table = validationCatalog.loadTable(tableIdent); + table.manageSnapshots().createBranch(BRANCH, table.currentSnapshot().snapshotId()).commit(); + sql("REFRESH TABLE " + tableName); + } + + @Override + protected String commitTarget() { + return String.format("%s.branch_%s", tableName, BRANCH); + } + + @Override + protected String selectTarget() { + return String.format("%s VERSION AS OF '%s'", tableName, BRANCH); + } + + @Test + public void testInsertIntoNonExistingBranchFails() { Review Comment: I will add a few more tests for MERGE, UPDATE and DELETE, but they go through the same SparkTable code path and will all fail at the same place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
