zhongyujiang commented on code in PR #7029:
URL: https://github.com/apache/iceberg/pull/7029#discussion_r1127283022
##########
core/src/main/java/org/apache/iceberg/io/DeleteSchemaUtil.java:
##########
@@ -29,7 +29,7 @@ private static Schema pathPosSchema(Schema rowSchema) {
return new Schema(
MetadataColumns.DELETE_FILE_PATH,
MetadataColumns.DELETE_FILE_POS,
- Types.NestedField.required(
+ Types.NestedField.optional(
Review Comment:
I have some concerns about this change, the `Delete Formats` spec says the
reason why this column type should be `required` is to make sure the statistics
of the deleted row values is accurate. I think the reason to make sure the
statistics are accurate is because of the manifest reader will use them to
filter delete files:
So I think if this type is changed to optional, the statistics will become
unreliable, which may cause the delete manifest entry to be incorrectly
filtered? This is just my understanding of the spec, but I'm not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
