nastra commented on code in PR #6952: URL: https://github.com/apache/iceberg/pull/6952#discussion_r1126045030
########## snowflake/src/main/java/org/apache/iceberg/snowflake/JdbcSnowflakeClient.java: ########## @@ -125,6 +130,15 @@ public <T> T query(Connection conn, String sql, ResultSetParser<T> parser, Strin private final JdbcClientPool connectionPool; private QueryHarness queryHarness; + @VisibleForTesting + static final Set<Integer> DATABASE_NOT_FOUND_ERROR_CODES = ImmutableSet.of(2001, 2003, 2043); + + @VisibleForTesting + static final Set<Integer> SCHEMA_NOT_FOUND_ERROR_CODES = ImmutableSet.of(2001, 2003, 2043); + + @VisibleForTesting + static final Set<Integer> TABLE_NOT_FOUND_ERROR_CODES = ImmutableSet.of(2001, 2003, 2043); Review Comment: are we expecting those 3 sets to eventually contain different error codes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
