danielcweeks commented on code in PR #6951:
URL: https://github.com/apache/iceberg/pull/6951#discussion_r1125340525
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -361,6 +383,55 @@ public void close() throws IOException {
httpClient.close(CloseMode.GRACEFUL);
}
+ public static HTTPClient buildFrom(Map<String, String> properties) {
Review Comment:
I've added a deprecation to the static builder method so that it's clear
which is supported going forward.
I don't feel the builder pattern here is a good approach because the
HTTPClient in Iceberg is already tightly coupled to the RESTCatalog
implementations due to request/response/exception types and just creates a
separate builder on top of the apache httpclient implementation. We should
just construct from the properties map, which will be much easier to extend
with new properties going foward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
