stevenzwu commented on code in PR #6949:
URL: https://github.com/apache/iceberg/pull/6949#discussion_r1119398639
##########
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java:
##########
@@ -386,25 +386,28 @@ private void commitOperation(
String operatorId,
long checkpointId) {
LOG.info(
- "Committing {} for checkpoint {} to table {} with summary: {}",
+ "Committing {} for checkpoint {} to table {} branch {} with summary:
{}",
description,
checkpointId,
table.name(),
+ branch,
summary);
snapshotProperties.forEach(operation::set);
// custom snapshot metadata properties will be overridden if they conflict
with internal ones
// used by the sink.
operation.set(MAX_COMMITTED_CHECKPOINT_ID, Long.toString(checkpointId));
operation.set(FLINK_JOB_ID, newFlinkJobId);
operation.set(OPERATOR_ID, operatorId);
+ operation.toBranch(branch);
long startNano = System.nanoTime();
operation.commit(); // abort is automatically called if this fails.
long durationMs = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() -
startNano);
LOG.info(
- "Committed {} to table: {}, checkpointId {} in {} ms",
+ "Committed {} to table: {}, branch: {}, checkpointId {} in {} ms",
Review Comment:
I will be fine if you just add it in this PR.
Can you check the diff output and make sure no diff related to this backport?
```
git diff --no-index flink/v1.14/flink/src/ flink/v1.16/flink/src
git diff --no-index flink/v1.15/flink/src/ flink/v1.16/flink/src
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
