danielcweeks commented on code in PR #6951:
URL: https://github.com/apache/iceberg/pull/6951#discussion_r1119373095
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -361,6 +383,54 @@ public void close() throws IOException {
httpClient.close(CloseMode.GRACEFUL);
}
+ public static HTTPClient buildFrom(Map<String, String> properties) {
Review Comment:
Switching from default builder pattern to property initialization pattern so
that we can expose configurations in the future for things like pool sizes,
request/response timeouts, etc. via properties as opposed to having to
replicate the apache http client builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
