namrathamyske commented on code in PR #6651:
URL: https://github.com/apache/iceberg/pull/6651#discussion_r1118993175
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java:
##########
@@ -82,6 +82,8 @@ public Long endSnapshotId() {
return
confParser.longConf().option(SparkReadOptions.END_SNAPSHOT_ID).parseOptional();
}
+ /** @deprecated will be removed in 1.3.0; specify read branch in the table
identifier */
+ @Deprecated
Review Comment:
Is this fine to be deprecated? We cannot read table by spark options at all
in this is done. My understanding was we use table identifiers for only write
options and we leave read as it is. since read by branch/tag is part of time
travel we should support read by spark options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
