[GitHub] [iceberg] tomtongue commented on a diff in pull request #6729: Docs: Add the description of creating a table using DataFrameWriterV2 with a table location

[via GitHub]

tomtongue commented on code in PR #6729:
URL: https://github.com/apache/iceberg/pull/6729#discussion_r1118314003


##########
docs/spark-writes.md:
##########
@@ -302,6 +302,14 @@ data.writeTo("prod.db.table")
     .createOrReplace()
 ```
 
+You can specify an Iceberg table location such as the `LOCATION` clause in SQL 
by add the `location` paramter to the `tableProperty`:

Review Comment:
   Thanks for reviewing this and the great suggenstion, Szehon! The following 
your suggestion is simpler and makes sense. Based on your suggestion, I updated 
a bit; `... table configuration` to `table property`. How about this?
   
   `The Iceberg table location can also be specified by the `location` table 
property.`
   
   
   For your comment;
   
   > Nit: I know there's a bad example above, but typically we avoid 'you' or 
'me' in documentation. you can see other reviews, for example: 
https://github.com/apache/iceberg/pull/4301#discussion_r823197799
   
   Thanks for pointing out, I understand it.
   
   > Also, I'm not sure why we reference "LOCATION" clause in SQL, which is 
documented elsewhere.
   
   I tried saying the `tableProperty("location", "...")` is the same as 
`LOCATION` in SQL, but the suggestion is better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org