LuigiCerone commented on code in PR #6892:
URL: https://github.com/apache/iceberg/pull/6892#discussion_r1116597288
##########
python/tests/expressions/test_parser.py:
##########
@@ -149,3 +151,13 @@ def test_and_or_with_parens() -> None:
assert Or(IsNull("x"), And(GreaterThanOrEqual("x", 5), Not(LessThan("x",
10)))) == parser.parse(
"(x is null) or (5 <= x) and not(x < 10)"
)
+
+
+def test_starts_with() -> None:
+ assert StartsWith("x", "data") == parser.parse("x starts_with 'data'")
Review Comment:
Yes you are right about the fact that `starts_with` is not common in SQL.
I'm just afraid that `LIKE` is a little misleading because in SQL it's to look
for a pattern in the whole string whereas here it would just be to look for
"starts with".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
