sumeetgajjar commented on PR #5629: URL: https://github.com/apache/iceberg/pull/5629#issuecomment-1442604561
> This seems a bit odd to me, to be honest. Why not use `scan.description()` in Spark for this? @aokolnychyi `SparkScan#description()` implemented in iceberg does not return a Table name but a lot of other info https://github.com/apache/iceberg/blob/3efaee1790fe541d0969e12fa24afa4e1a3041c3/spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java#L161-L171 Futhermore, `scan#description()` from `FileScan` in Spark also returns a lot more info including `Tablename` thus it made sense to use `Table#name()` https://github.com/apache/spark/blob/0b9ed26e48248aa58642b3626a02dd8c89a01afb/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileScan.scala#L110-L130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
