dramaticlly commented on code in PR #6889:
URL: https://github.com/apache/iceberg/pull/6889#discussion_r1112387718
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
##########
@@ -103,6 +103,35 @@ public void addDataUnpartitioned() {
sql("SELECT * FROM %s ORDER BY id", tableName));
}
+ @Test
+ public void deleteAndAddBackAllowed() {
Review Comment:
I think this is a good callout to verify the add-files behaviour for v2 in
general, which I dont see any coverage in existing tests.
Focus on this particular PR, I think no matter v1 or v2, we shall not rely
duplicate check based on file path only, the file path with deleted status will
go away on next snapshot, so the current workaround before this fix is simply
force a new snapshot between DELETE and add-files procedure call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
