szehon-ho commented on code in PR #6779: URL: https://github.com/apache/iceberg/pull/6779#discussion_r1112267916
########## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ########## @@ -836,19 +836,47 @@ public static String quotedFullIdentifier(String catalogName, Identifier identif * @param format format of the file * @param partitionFilter partitionFilter of the file * @return all table's partitions + * @deprecated use {@link Spark3Util#getPartitions(SparkSession, Path, String, Map, + * PartitionSpec)} */ + @Deprecated Review Comment: Nit: i think its still valid to have this API, and no need to deprecate? If you want to infer the partition spec from the path. wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org