rdblue commented on code in PR #6850:
URL: https://github.com/apache/iceberg/pull/6850#discussion_r1110457980
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -88,6 +89,7 @@ public class RESTSessionCatalog extends BaseSessionCatalog
implements Configurable<Configuration>, Closeable {
private static final Logger LOG =
LoggerFactory.getLogger(RESTSessionCatalog.class);
private static final String REST_METRICS_REPORTING_ENABLED =
"rest-metrics-reporting-enabled";
+ private static final String REST_SNAPSHOT_LOADING_MODE =
"rest-snapshot-loading-mode";
Review Comment:
I think this should just be `snapshot-loading-mode`.
The reason why we added the `rest-` prefix for metrics reporting is that we
report metrics in multiple ways, one of which is to always report through the
REST interface. Because you can set the metrics reporter and choose whether to
send REST metrics separately, we needed to distinguish the option. But that's
not a problem for snapshot loading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
