danielcweeks commented on code in PR #6835:
URL: https://github.com/apache/iceberg/pull/6835#discussion_r1109306790
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -105,6 +105,12 @@ public String token() {
return properties().get(OAuth2Properties.TOKEN);
}
+ /**
+ * A token supplier that takes precedence over {@link
S3V4RestSignerClient#token()} if it's set.
+ */
+ @Nullable
+ public abstract Supplier<String> tokenSupplier();
Review Comment:
I feel like it's unnecessary to have both `token()` and `tokenSupplier()`.
I think we should just make `token()` be a supplier and then the default can
always be `properties().get(OAuth2Properties.TOKEN`. Having duplicates with
precedence considerations just makes it more complicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
