dramaticlly commented on code in PR #6838:
URL: https://github.com/apache/iceberg/pull/6838#discussion_r1107984679
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -207,6 +207,7 @@ public DistributionMode distributionMode() {
confParser
.stringConf()
.option(SparkWriteOptions.DISTRIBUTION_MODE)
+ .sessionConf(SparkSQLProperties.SESSION_WRITE_DISTRIBUTION_MODE)
Review Comment:
Also needs to thinking of a best way to test all those methods. I guess the
core is to verify the config inheritance to see how its precedence level is
being received, regardless of distribution mode is used for insert, delete,
update or merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
