szehon-ho commented on code in PR #6771:
URL: https://github.com/apache/iceberg/pull/6771#discussion_r1107525871


##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -170,6 +170,8 @@ static CloseableIterable<FileScanTask> 
planFiles(StaticTableScan scan) {
                       scan.filter(), transformedSpec, caseSensitive);
                 });
 
+    // Note, the delete files aren't applied to the data files so if there are 
partition values that
+    // have been updated then both the 'old' and the 'new' values are present 
in the output.

Review Comment:
   Yea I was trying to say, maybe on the class itself?  (Initially thinking 
method, but it's a overriden one)  Anyway change looks good to me as is, up to 
you if you want to put it on there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to