Fokko commented on issue #6798: URL: https://github.com/apache/iceberg/issues/6798#issuecomment-1431247665
Feel free to ask any question, even the rudimental ones :) > Let me know if my assumption is correct so far, cause my later statements/questions are based on them. This assumption is correct. The Java code is the implementation of the [Iceberg table specification](https://iceberg.apache.org/spec/). And, coincidentally they are the same. I think this is the main reason that changing is difficult we don't want them to diverge. The `RESTSerializers.java` use the TableMetadata (de)serializer from core: https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/rest/RESTSerializers.java#L108-L123 > Q1: But shouldn't the rest service return an object named [LoadTableResponse](https://github.com/apache/iceberg/blob/master/open-api/rest-catalog-open-api.yaml#L2310) as defined by OpenAPI? You mean `LoadTableResult`? Looking at the spec, I think the author wasn't super consistent with `Response` and `Result`. I think renaming `LoadTableResult` to `LoadTableResponse` in the Open API Spec makes sense to avoid confusion. > Q2: On Q2: I understand your point that there needs to be two sets of model so that we could maintain backward compatibility for the existing Tables (metadata, snapshots, etc.)? Conceptually, if we technically have a way to merge these two sets of models (which are conceptually for the same purpose), then would it make things easier by eliminating the need of an "converter/adapter" between the 2? The models overlap, but we should probably make this more clear in the docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
