snazy commented on code in PR #6826: URL: https://github.com/apache/iceberg/pull/6826#discussion_r1107000504
########## build.gradle: ########## @@ -258,6 +265,16 @@ project(':iceberg-api') { tasks.processTestResources.dependsOn rootProject.tasks.buildInfo + // Workaround to prevent: + // Task ':iceberg-api:processTestResources' uses this output of task + // ':spotlessInternalRegisterDependencies' without declaring an explicit or implicit dependency. Review Comment: Maybe. Cross-project task dependencies are never a good idea. ########## build.gradle: ########## @@ -219,7 +226,7 @@ project(':iceberg-bundled-guava') { } shadowJar { - classifier null + archiveClassifier.set(null) Review Comment: updated those -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org