aokolnychyi commented on code in PR #6716:
URL: https://github.com/apache/iceberg/pull/6716#discussion_r1105117600
##########
core/src/main/java/org/apache/iceberg/PositionDeletesTable.java:
##########
@@ -43,15 +43,21 @@
public class PositionDeletesTable extends BaseMetadataTable {
private final Schema schema;
+ private final int defaultSpecId;
+ private final Map<Integer, PartitionSpec> specs;
PositionDeletesTable(Table table) {
- super(table, table.name() + ".position_deletes");
- this.schema = calculateSchema();
+ this(table, ".position_deletes");
Review Comment:
Is this supposed to be `table.name() + ".position_deletes"`?
##########
core/src/main/java/org/apache/iceberg/PositionDeletesTable.java:
##########
@@ -43,15 +43,21 @@
public class PositionDeletesTable extends BaseMetadataTable {
private final Schema schema;
+ private final int defaultSpecId;
+ private final Map<Integer, PartitionSpec> specs;
PositionDeletesTable(Table table) {
- super(table, table.name() + ".position_deletes");
- this.schema = calculateSchema();
+ this(table, ".position_deletes");
}
PositionDeletesTable(Table table, String name) {
super(table, name);
this.schema = calculateSchema();
+ this.defaultSpecId = table.spec().specId();
+ this.specs =
Review Comment:
What about adding `transformSpecs` to `BaseMetadataTable` that would take a
map of original specs? I think you need the same code below in the scan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
