rdblue commented on code in PR #6622:
URL: https://github.com/apache/iceberg/pull/6622#discussion_r1103892380
##########
api/src/main/java/org/apache/iceberg/expressions/BoundAggregate.java:
##########
@@ -18,18 +18,40 @@
*/
package org.apache.iceberg.expressions;
+import java.util.Map;
+import org.apache.iceberg.DataFile;
import org.apache.iceberg.StructLike;
import org.apache.iceberg.types.Type;
import org.apache.iceberg.types.Types;
public class BoundAggregate<T, C> extends Aggregate<BoundTerm<T>> implements
Bound<C> {
+
+ // indicates if there are enough stats for this aggregate to be calculated at
+ // iceberg side.
+ private boolean canPushDown = false;
Review Comment:
Aggregate expressions can't be mutable. The `AggregateEvaluator` is the
mutable state that gets created for every aggregation.
Sorry about not being clear, I think the problem was that I referred to
"aggregator" when I meant `AggregateEvaluator`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
