wypoon commented on code in PR #5893:
URL: https://github.com/apache/iceberg/pull/5893#discussion_r1102204451


##########
core/src/test/java/org/apache/iceberg/TableTestBase.java:
##########
@@ -163,6 +166,19 @@ public class TableTestBase {
 
   static final FileIO FILE_IO = new TestTables.LocalFileIO();
 
+  static final Map<String, String> CODEC_METADATA_MAPPING =
+      ImmutableMap.<String, String>builder()
+          .put("uncompressed", "null")

Review Comment:
   I don't see much benefit to using `Avro.Codec`. You'd have to get the name 
from the enum and then lowercase it. I think in this case, plain strings are 
fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to