haizhou-zhao commented on code in PR #6621:
URL: https://github.com/apache/iceberg/pull/6621#discussion_r1102184009
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -494,6 +494,17 @@ private void setHmsTableParameters(
// remove any props from HMS that are no longer present in Iceberg table
props
obsoleteProps.forEach(parameters::remove);
+ // altering owner
+ if (metadata.properties().get(HiveCatalog.HMS_TABLE_OWNER) != null) {
+ tbl.setOwner(metadata.properties().get(HiveCatalog.HMS_TABLE_OWNER));
+ }
+
+ // dropping owner: instead of leaving the owner blank/null, the owner will
be
+ // default to whoever is making the current drop operation
+ if (obsoleteProps.contains(HiveCatalog.HMS_TABLE_OWNER)) {
Review Comment:
Thanks @gaborkaszab.
First, I think altering and dropping ownership are both doable even if not
having owner property in iceberg Metadata. Maybe more if branches, but
ultimately should be achievable.
Summarizing our discussion above, the core question is: whether or not
"owner" is an iceberg table/namespace property.
@gaborkaszab I think you are arguing that the answer should be no, and I
agree that all your points make perfect sense when the answer is no (that the
"owner" property should have no business with Iceberg Metadata and should only
be tracked by the metastore/catalog service people uses, whether it's Hive,
Nessie, DynamoDB or JDBC)
@szehon-ho and @danielcweeks would love to hear your opinion and vote before
committing further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
