stevenzwu commented on code in PR #6764:
URL: https://github.com/apache/iceberg/pull/6764#discussion_r1098992688
##########
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitterMetrics.java:
##########
@@ -37,6 +40,9 @@ class IcebergFilesCommitterMetrics {
metrics.addGroup("IcebergFilesCommitter").addGroup("table",
fullTableName);
committerMetrics.gauge("lastCheckpointDurationMs",
lastCheckpointDurationMs::get);
committerMetrics.gauge("lastCommitDurationMs", lastCommitDurationMs::get);
+ this.elapsedSecondsSinceLastSuccessfulCommit = new
ElapsedTimeGauge(TimeUnit.SECONDS);
Review Comment:
Iceberg commit happens after a successful checkpoint. Iceberg commits can
fail (for whatever reason) while Flink checkpoints succeeded. this metric is
very useful to set up alerts to detect consecutive Iceberg commit failures.
Will send a separate PR for doc on FlinkSink metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
