pvary commented on code in PR #6614:
URL: https://github.com/apache/iceberg/pull/6614#discussion_r1098200427
##########
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/TableLoader.java:
##########
@@ -34,12 +34,16 @@
* the cluster (for example, to get splits), not just on the client side. So
we need an Iceberg
* table loader to get the {@link Table} object.
*/
-public interface TableLoader extends Closeable, Serializable {
+public interface TableLoader extends Closeable, Serializable, Cloneable {
void open();
Table loadTable();
+ /** By shallow cloning, clone a tableLoader. */
+ @SuppressWarnings("checkstyle:NoClone")
Review Comment:
@xuzhiwen1255: If there's no strong reason against it, then I would go for
the full clone too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
