jackye1995 commented on code in PR #6449:
URL: https://github.com/apache/iceberg/pull/6449#discussion_r1098151723
##########
build.gradle:
##########
@@ -438,6 +442,77 @@ project(':iceberg-aws') {
}
}
+project(':iceberg-delta-lake') {
+ // use integration test since we can take advantages of spark 3.3 to read
datafiles of delta lake table
+ // and create some tests involving sql query.
+ configurations {
+ integrationImplementation.extendsFrom testImplementation
+ integrationRuntime.extendsFrom testRuntimeOnly
+ }
+
+ dependencies {
+ implementation project(path: ':iceberg-bundled-guava', configuration:
'shadow')
+ api project(':iceberg-api')
+ implementation project(':iceberg-common')
+ implementation project(':iceberg-core')
+ implementation project(':iceberg-parquet')
+ implementation project(':iceberg-orc')
Review Comment:
good point about testing coverage, +1 for removing ORC and Avro in that
case, it will make the codebase a lot simpler as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
