amogh-jahagirdar commented on code in PR #6682: URL: https://github.com/apache/iceberg/pull/6682#discussion_r1092454022
########## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/BaseSparkAction.java: ########## @@ -85,6 +88,7 @@ private static final Logger LOG = LoggerFactory.getLogger(BaseSparkAction.class); private static final AtomicInteger JOB_COUNTER = new AtomicInteger(); private static final int DELETE_NUM_RETRIES = 3; + private static final int DELETE_GROUP_SIZE = 100000; Review Comment: yeah that makes sense, I was thinking that since the deletion is done on the driver people would want control over how much is brought into memory, but we don't need to overcomplicate it. 100000 seems like a good default -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
