youngxinler commented on code in PR #6571:
URL: https://github.com/apache/iceberg/pull/6571#discussion_r1090226814
##########
docs/java-api.md:
##########
@@ -147,6 +147,59 @@ t.newAppend().appendFile(data).commit();
t.commitTransaction();
```
+### WriteData
+
+The java api can write data into iceberg table.
+
+First write data to the data file, then submit the data file, the data you
write will take effect in the table.
+
+For example, add 1000 pieces of data to the table.
+
+```java
+/**
+ * The structure of this table is the same as the demo table in
java-api-quickstart
+ *
+ * Schema schema = new Schema(
+ * Types.NestedField.required(1, "level", Types.StringType.get()),
+ * Types.NestedField.required(2, "event_time",
Types.TimestampType.withZone()),
+ * Types.NestedField.required(3, "message", Types.StringType.get()),
+ * Types.NestedField.optional(4, "call_stack",
Types.ListType.ofRequired(5, Types.StringType.get()))
+ * );
+ * PartitionSpec spec = PartitionSpec.builderFor(schema)
+ * .hour("event_time")
+ * .identity("level")
+ * .build();
+ */
+
+GenericAppenderFactory appenderFactory = new
GenericAppenderFactory(table.schema(), table.spec());
Review Comment:
> What if we put this as a test, and directly reference the test as example
in the doc page? By doing that the code can be up to date with latest API and
checkstyle standards.
thanks for @jackye1995 review, that sounds good, i change test code and doc
demo code make them same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
