RussellSpitzer commented on PR #6680: URL: https://github.com/apache/iceberg/pull/6680#issuecomment-1407483685
> Looks correct to me, though we may want to move to `StructLikeMap` that was introduced later. `metricsEvaluators` is a struct like map which when putting copies the Wrapper but not the internal struct data. Since the underlying object reference is not copied we have the same issue. https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/util/StructLikeMap.java#L86 and then https://github.com/apache/iceberg/blob/a76724f7ae7ff3722fea3e1145aa0a978c721b45/core/src/main/java/org/apache/iceberg/util/StructLikeWrapper.java#L59 Since the "set" method just assigns `this.struct = newStruct` we have this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
