jackye1995 commented on code in PR #6169:
URL: https://github.com/apache/iceberg/pull/6169#discussion_r1089652523
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -1119,6 +1139,54 @@ public <T extends S3ClientBuilder> void
applyS3ServiceConfigurations(T builder)
.build());
}
+ /**
+ * Configure a signer for an S3 client.
+ *
+ * <p>Sample usage:
+ *
+ * <pre>
+ *
S3Client.builder().applyMutation(awsProperties::applyS3SignerConfiguration)
+ * </pre>
+ */
+ public <T extends S3ClientBuilder> void applyS3SignerConfiguration(T
builder) {
+ if (null != s3SignerImpl) {
+ builder.overrideConfiguration(
+ c -> c.putAdvancedOption(SdkAdvancedClientOption.SIGNER,
loadS3SignerDynamically()));
+ }
+ }
+
+ @SuppressWarnings("checkstyle:NestedTryDepth")
+ private Signer loadS3SignerDynamically() {
+ // load the signer implementation dynamically
+ Object signer;
+ try {
+ signer =
+ DynMethods.builder("of")
Review Comment:
I think I get why we want to break the pattern of dynamic initialization
because of using Immutable, I will leave that part to Ryan to make a call to
use that for the signer class or not. But can we at least use a method name
that is more intuitive to readers of this code, such as `initialize`, instead
of `of`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
