[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #6676: Nessie : use default namespace location if exists

[via GitHub]

ajantha-bhat commented on code in PR #6676:
URL: https://github.com/apache/iceberg/pull/6676#discussion_r1089010582


##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java:
##########
@@ -202,7 +202,16 @@ protected TableOperations newTableOps(TableIdentifier 
tableIdentifier) {
   protected String defaultWarehouseLocation(TableIdentifier table) {
     String location;
     if (table.hasNamespace()) {
-      location = SLASH.join(warehouseLocation, table.namespace().toString(), 
table.name());
+      String baseLocation;
+      try {
+        baseLocation =
+            loadNamespaceMetadata(table.namespace())
+                .getOrDefault(
+                    "location", SLASH.join(warehouseLocation, 
table.namespace().toString()));

Review Comment:
   > If the namespace it's created using flink, spark or hive at least like 
'CREATE namespace t LOCATION 'somewhere'' it will populate this "location" 
property.
   
   Thanks. Then it is already standardized. I was not aware of this (I assumed 
the user has to manually configure the property bag). I agree with your code 
changes. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org