amogh-jahagirdar commented on code in PR #6598: URL: https://github.com/apache/iceberg/pull/6598#discussion_r1088481012
########## core/src/main/java/org/apache/iceberg/view/ViewRepresentationParser.java: ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.view; + +import com.fasterxml.jackson.core.JsonGenerator; +import com.fasterxml.jackson.databind.JsonNode; +import java.io.IOException; +import java.util.Locale; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.util.JsonUtil; + +class ViewRepresentationParser { + static final String TYPE = "type"; + + private ViewRepresentationParser() {} + + static void toJson(ViewRepresentation representation, JsonGenerator generator) + throws IOException { + Preconditions.checkArgument(representation != null, "Invalid view representation: null"); + switch (representation.type()) { + case ViewRepresentation.Type.SQL: + SQLViewRepresentationParser.toJson((SQLViewRepresentation) representation, generator); + break; + + default: + throw new IllegalArgumentException( + String.format("Cannot serialize view representation type: %s", representation.type())); + } + } + + static String toJson(ViewRepresentation entry) { + return JsonUtil.generate(gen -> toJson(entry, gen), false); + } + + static ViewRepresentation fromJson(String json) { + return JsonUtil.parse(json, ViewRepresentationParser::fromJson); + } + + static ViewRepresentation fromJson(JsonNode node) { + Preconditions.checkArgument(node != null, "Cannot parse view representation from null object"); + Preconditions.checkArgument( + node.isObject(), "Cannot parse view representation from non-object: %s", node); + String type = JsonUtil.getString(TYPE, node).toLowerCase(Locale.ENGLISH); + switch (type) { + case "sql": + return SQLViewRepresentationParser.fromJson(node); + + default: + return ImmutableUnknownViewRepresentation.builder().type(type).build(); Review Comment: I was checking this, if we consider this similar to the [UnknownTransform](https://github.com/apache/iceberg/blob/master/api/src/main/java/org/apache/iceberg/transforms/UnknownTransform.java#L28) then it's never really treated as a warning case, and also it seems like Iceberg doesn't do any logging in parsers (although we don't necessarily need to follow that here). I was thinking if we do want to consider this as a warning case we may want to do it in the higher level metadata parser. After reading the representation list field, we would go record by record and if the read result is an instance of UnknownViewrepresentation than we can log there. But overall, I'm not sure if we even want to treat this as a warning case in the parser level? I think engines integrating with the view spec would do hard validations like uhttps://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/Partitioning.java#L261 which will ultimately fail if there's unknown representations and get surfaced to a user . let me know your thoughts here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
