jackye1995 commented on code in PR #6646:
URL: https://github.com/apache/iceberg/pull/6646#discussion_r1088118591
##########
python/pyiceberg/catalog/hive.py:
##########
@@ -548,10 +511,9 @@ def update_namespace_properties(
for key, value in updates.items():
parameters[key] = value
updated.add(key)
+
open_client.alter_database(database_name,
_annotate_namespace(database, parameters))
expected_to_change = (removals or set()).difference(removed)
- return PropertiesUpdateSummary(
- removed=list(removed or []), updated=list(updates.keys() if
updates else []), missing=list(expected_to_change)
- )
+ return PropertiesUpdateSummary(removed=list(removed or []),
updated=list(updated or []), missing=list(expected_to_change))
Review Comment:
I see there are multiple places with this kind of style change and newline
additions. If not required by linter, can we avoid these changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
