amogh-jahagirdar commented on code in PR #6660:
URL: https://github.com/apache/iceberg/pull/6660#discussion_r1087244952


##########
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/SimpleDataUtil.java:
##########
@@ -284,10 +303,23 @@ public static void assertTableRecords(Table table, 
List<Record> expected) throws
     }
   }
 
+  public static Snapshot latestSnapshot(Table table, String branch) {

Review Comment:
   Technically `table.snapshot(branch)` would also yield the same results but 
refer to @rdblue 
[comment](https://github.com/apache/iceberg/pull/6651/files#r1085892442) on the 
Spark write PR.
   
   For the main branch we still want to validate the behavior of specifically 
currentSnapshot() is maintained since that was the original check done here. 
This will effectively ensure that the currentSnapshotId in metadata is 
maintained correctly as the main branch gets written to. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to