RussellSpitzer commented on code in PR #6624:
URL: https://github.com/apache/iceberg/pull/6624#discussion_r1084336485
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java:
##########
@@ -405,14 +405,16 @@ private static Iterator<ManifestFile> buildManifest(
* @param partitionFilter only import partitions whose values match those in
the map, can be
* partially defined
* @param checkDuplicateFiles if true, throw exception if import results in
a duplicate data file
+ * @param parallelism Controls max concurrency of file reads per partition
*/
public static void importSparkTable(
Review Comment:
Unfortunately this is a public api, We should probably add a new signature
and deprecate the old one, or keep the old one. I think in this case keeping
the old one without deprecation is fine but we probably should not break binary
compatibility unless we have to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
