XN137 commented on PR #6629: URL: https://github.com/apache/iceberg/pull/6629#issuecomment-1399910688
if these warnings are worth fixing, shouldnt they also be worth preventing? automatic prevention is usually cheaper than manually observing and fixing future warnings. this also has the added benefit that we are sure this PR addressed all these types of violations, not just the ones you happened to see. i dont see how the existence of other errorprone checks, that are not being enforced, matters in this discussion. ideally all of the checks we agree are worth fixing should be enforced... the problem is identifying those and addressing all their current violations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
