namrathamyske commented on code in PR #5234:
URL: https://github.com/apache/iceberg/pull/5234#discussion_r1083386045
##########
core/src/main/java/org/apache/iceberg/BaseRowDelta.java:
##########
@@ -96,23 +97,37 @@ public RowDelta validateNoConflictingDeleteFiles() {
}
@Override
- protected void validate(TableMetadata base, Snapshot snapshot) {
- if (base.currentSnapshot() != null) {
+ public RowDelta toBranch(String branch) {
+ targetBranch(branch);
+ return this;
+ }
+
+ @Override
+ protected void validate(TableMetadata base, Snapshot parent) {
+ if (parent != null) {
+ if (startingSnapshotId != null) {
+ Preconditions.checkArgument(
+ SnapshotUtil.isAncestorOf(parent.snapshotId(), startingSnapshotId,
base::snapshot),
+ "Snapshot %s is not an ancestor of %s",
Review Comment:
@amogh-jahagirdar Is this even required anymore ? We are anyway doing
ancestor check in
https://github.com/apache/iceberg/blob/a1d994c131dc5b5f42e1693e92e058493382593e/core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java#L742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
