szehon-ho commented on code in PR #6365: URL: https://github.com/apache/iceberg/pull/6365#discussion_r1083117603
########## core/src/main/java/org/apache/iceberg/BasePositionDeletesScanTask.java: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import org.apache.iceberg.expressions.ResidualEvaluator; + +/** Base implememntation of {@link PositionDeletesScanTask} */ +class BasePositionDeletesScanTask extends BaseContentScanTask<PositionDeletesScanTask, DeleteFile> + implements PositionDeletesScanTask, SplittableScanTask<PositionDeletesScanTask> { + + BasePositionDeletesScanTask( + DeleteFile file, String schemaString, String specString, ResidualEvaluator evaluator) { + super(file, schemaString, specString, evaluator); + } + + @Override + protected BasePositionDeletesScanTask self() { + return this; + } + + @Override + protected PositionDeletesScanTask newSplitTask( + PositionDeletesScanTask parentTask, long offset, long length) { + return new SplitPositionDeletesScanTask(parentTask, offset, length); Review Comment: Ill keep it a separate class as there's enough content imo to be clearer in its own class. ########## core/src/main/java/org/apache/iceberg/BasePositionDeletesScanTask.java: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import org.apache.iceberg.expressions.ResidualEvaluator; + +/** Base implememntation of {@link PositionDeletesScanTask} */ Review Comment: Good catch, changed. ########## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ########## @@ -73,9 +73,12 @@ protected BaseMetadataTable(Table table, String name) { */ static PartitionSpec transformSpec(Schema metadataTableSchema, PartitionSpec spec) { PartitionSpec.Builder identitySpecBuilder = - PartitionSpec.builderFor(metadataTableSchema).checkConflicts(false); + PartitionSpec.builderFor(metadataTableSchema) + .withSpecId(spec.specId()) + .checkConflicts(false); for (PartitionField field : spec.fields()) { Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
