[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #6365: Core: Add position deletes metadata table

[via GitHub]

aokolnychyi commented on code in PR #6365:
URL: https://github.com/apache/iceberg/pull/6365#discussion_r1083088187


##########
core/src/main/java/org/apache/iceberg/BaseMetadataTable.java:
##########
@@ -64,9 +64,12 @@ protected BaseMetadataTable(TableOperations ops, Table 
table, String name) {
    */
   static PartitionSpec transformSpec(Schema metadataTableSchema, PartitionSpec 
spec) {
     PartitionSpec.Builder identitySpecBuilder =
-        PartitionSpec.builderFor(metadataTableSchema).checkConflicts(false);
+        PartitionSpec.builderFor(metadataTableSchema)
+            .withSpecId(spec.specId())
+            .checkConflicts(false);
     for (PartitionField field : spec.fields()) {
-      identitySpecBuilder.add(field.fieldId(), field.name(), 
Transforms.identity());
+      identitySpecBuilder.add(
+          field.fieldId(), field.fieldId(), field.name(), 
Transforms.identity());

Review Comment:
   Let me resolve this one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org