szehon-ho commented on code in PR #6410:
URL: https://github.com/apache/iceberg/pull/6410#discussion_r1082942925
##########
core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java:
##########
@@ -301,4 +305,16 @@ protected static String fullTableName(String catalogName,
TableIdentifier identi
return sb.toString();
}
+
+ private MetricsReporter metricsReporter() {
+ if (metricsReporter == null) {
+ metricsReporter =
+ properties().containsKey(CatalogProperties.METRICS_REPORTER_IMPL)
+ ? CatalogUtil.loadMetricsReporter(
+ properties().get(CatalogProperties.METRICS_REPORTER_IMPL))
+ : LoggingMetricsReporter.instance();
Review Comment:
Makes sense, sorry I didnt have the context but wonder is there enough value
to always fill the logs every time? But agree its not part of this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
